CDFs for EB announcements - #6639
Merged
Merged
Conversation
coot
added
the
leios
nfrisby
requested changes
Aug 5, 2026
|
|
||
| data Config = Config { numOfDataPoints :: Int } | ||
|
|
||
| -- | Default `Config` keeps `k/2` data points. |
Contributor
There was a problem hiding this comment.
The proportionality to k is easier to justify for some CDFs than for others, but it's probably fine for most?
Contributor
There was a problem hiding this comment.
But one other option is to just force each callers to choose a number
Contributor
Author
There was a problem hiding this comment.
That's how it's done, we just happen to provide a defaultConfig which is used by all applications (block-fetch and leios announcements). Do you have a better value for leios announcment?
ch1bo
force-pushed
the
leios-prototype
branch
9 times, most recently
from
August 10, 2026 06:06
2c5ed69 to
22d7144
Compare
* Moved to a new module * Provide re-usable API This is a preparation work for re-using the CDF calculations for Leios.
nfrisby
approved these changes
Aug 18, 2026
nfrisby
left a comment
nfrisby
left a comment
Contributor
There was a problem hiding this comment.
There are some "typo"-level minor issues in this thread https://github.com/IntersectMBO/cardano-node/pull/6639/changes#r3722072409 but otherwise looks good to me. Thanks for addressing my comments 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
See Running tests for more details
CHANGELOG.mdfor affected packagecardano-node-chairman,cardano-submit-apiandcardano-testnetinstead need achangelog fragment in
<package>/.changes/, because theirCHANGELOG.mdis generatedfrom fragments at release time. Copy
_TEMPLATE.ymlfrom that directory, or runnix run github:input-output-hk/cardano-dev#herald -- new.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.